Re: [PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

2016-09-06 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D24083#534459, @logan wrote: > One solution might be adding the `libclang_rt.builtins.${arch}.a` detection > rules[1] to CMakeLists.txt, and manually specify > `-lclang_rt.builtins-${arch}.a` when `LIBCXXABI_USE_COMPILER_RT` is enabled. >

Re: [PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

2016-09-06 Thread Logan Chien via cfe-commits
logan added a comment. Hi @rengolin and @EricWF, After tracing the commit log of clang, it seems that `--rtlib=` is ignored intentionally when `-nodefaultlibs` is present. (see also: https://reviews.llvm.org/rL254535) And, unfortunately, we don't have a command line option to ask clang to

Re: [PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

2016-09-03 Thread Eric Fiselier via cfe-commits
EricWF added a comment. This is not correct. We need the `-nodefaultlibs` on most platforms to prevent libstdc++ from being linked. I think the correct fix is to change `--rtlib=` https://reviews.llvm.org/D24083 ___ cfe-commits mailing list

Re: [PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

2016-08-31 Thread Renato Golin via cfe-commits
rengolin added a comment. This looks like a work around the fact that --rtlib is being ignored with --nodefaultlibs. I'm not sure that's a sane behaviour, if you explicitly specify --rtlib. https://reviews.llvm.org/D24083 ___ cfe-commits mailing