Re: [PATCH] D24877: [libc++] Default to DLL semantics on Windows

2016-09-26 Thread Shoaib Meenai via cfe-commits
smeenai abandoned this revision. smeenai added a comment. Your patch looks good to me and is a nicer way of accomplishing this. Thanks for taking care of it! https://reviews.llvm.org/D24877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24877: [libc++] Default to DLL semantics on Windows

2016-09-26 Thread Eric Fiselier via cfe-commits
EricWF resigned from this revision. EricWF removed a reviewer: EricWF. EricWF added a comment. I fixed this with a slightly different patch in r282449. I hope you don't mind that I didn't use this patch, I just wanted to add support for generating custom __config headers for static builds on