Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread Shoaib Meenai via cfe-commits
sts.llvm.org" <cfe-commits@lists.llvm.org>, "ztur...@google.com" <ztur...@google.com> Subject: Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks If the thinks are not imported, why would it make sense to export them? Maybe devirtualization could trigger this? On

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread David Majnemer via cfe-commits
a22767368a5b...@reviews.llvm.org>, "r...@google.com" > <r...@google.com> > Cc: "ztur...@google.com" <ztur...@google.com>, "cfe-commits@lists.llvm.org" > <cfe-commits@lists.llvm.org> > Subject: Re: [PATCH] D34972: [CodeGen] Propagate

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread Shoaib Meenai via cfe-commits
+d34972+public+8a22767368a5b...@reviews.llvm.org>, "r...@google.com" <r...@google.com> Cc: "ztur...@google.com" <ztur...@google.com>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> Subject: Re: [PATCH] D34972: [CodeGen] Propagate dllexport t

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

2017-07-05 Thread David Majnemer via cfe-commits
What about the import side? On Mon, Jul 3, 2017 at 10:37 PM Shoaib Meenai via Phabricator via cfe-commits wrote: > smeenai created this revision. > > Under Windows Itanium, we need to export virtual and non-virtual thunks > if the functions being thunked are