Re: r295252 - [Modules] Consider enable_if attrs in isSameEntity.

2017-02-23 Thread George Burgess IV via cfe-commits
WFM; added them to ExtParameterInfo in r296076. Thanks for the idea! On Wed, Feb 15, 2017 at 5:44 PM, Richard Smith wrote: > On 15 February 2017 at 17:32, George Burgess IV < > george.burgess...@gmail.com> wrote: > >> I remember that we wanted to pretend that

Re: r295252 - [Modules] Consider enable_if attrs in isSameEntity.

2017-02-15 Thread Richard Smith via cfe-commits
On 15 February 2017 at 17:32, George Burgess IV wrote: > I remember that we wanted to pretend that pass_object_size isn't a part of > the FunctionType during the review that added it, though. > I remember we wanted to not add extra fake "parameters" to the

Re: r295252 - [Modules] Consider enable_if attrs in isSameEntity.

2017-02-15 Thread George Burgess IV via cfe-commits
I remember that we wanted to pretend that pass_object_size isn't a part of the FunctionType during the review that added it, though. Do you think that would be better than serializing parameters before we serialize template info? AFAICT, we only do merging after we start reading the template info,

Re: r295252 - [Modules] Consider enable_if attrs in isSameEntity.

2017-02-15 Thread Richard Smith via cfe-commits
On 15 February 2017 at 14:43, George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gbiv > Date: Wed Feb 15 16:43:27 2017 > New Revision: 295252 > > URL: http://llvm.org/viewvc/llvm-project?rev=295252=rev > Log: > [Modules] Consider enable_if attrs in isSameEntity. > >