Re: r300001 - Revert r298824 & r298816, recommit r298742 & r298754

2017-04-12 Thread Richard Trieu via cfe-commits
Yup, that looks like my fault, again. Thanks, Greg, for the test case. It's very similar to the final test in odr_hash.cc, which I thought I had fixed. On Wed, Apr 12, 2017 at 8:09 AM, Greg Bedwell wrote: > We're seeing the same assertion failing in our internal testing

Re: r300001 - Revert r298824 & r298816, recommit r298742 & r298754

2017-04-12 Thread Greg Bedwell via cfe-commits
We're seeing the same assertion failing in our internal testing (I've not bisected to a specific change yet though, but it seems likely it's the same thing as in the log from the modules bot). Here's a reduced example that triggers it: $ cat 2.h //

Re: r300001 - Revert r298824 & r298816, recommit r298742 & r298754

2017-04-11 Thread Richard Smith via cfe-commits
Either this or your other ODR hash change seems to have broken the modules buildbot: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/6274/steps/compile.llvm.stage2/logs/stdio On 11 April 2017 at 15:32, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org>