Re: r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

2019-10-11 Thread Craig Topper via cfe-commits
I think _MSC_VER is controlled by -ms-compatiblity-version based on what I found when I was missing with the bmiintrin.h header yesterday. ~Craig On Fri, Oct 11, 2019 at 3:05 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I think overloading zero to mean "don't define

Re: r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

2019-10-11 Thread Reid Kleckner via cfe-commits
I think overloading zero to mean "don't define __GNUC__" was my way of side stepping the need to think of a good name for this. I don't like -fno-gnu-extensions as a name because clang still supports GCC asm, __attribute__, statement expressions, computed goto, etc, and that flag name seems like

Re: r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

2019-10-11 Thread Nico Weber via cfe-commits
It's cool we finally have a flag for this, but overloading its meaning with the =0 behavior seems a bit strange to me. Maybe we should have a separate -fno-gnu-extensions for that part instead? On Thu, Oct 10, 2019 at 5:02 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: >