[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf7086fe: [clang-tidy] modernize-use-override new option AllowOverrideAndFinal (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D70165?vs=229632&id=230040

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reopening in order to correct the accidentally swapped commits between this ticket and https://reviews.llvm.org/D69238. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

lebedev.ri added a comment. In D70165#1751402 , @mitchell-stellar wrote: > Oops, it looks like I mixed up this ticket with > https://reviews.llvm.org/D69238. Sorry about that. Would you like me to > revert both commits and then re-commit with the correc

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar added a comment. Oops, it looks like I mixed up this ticket with https://reviews.llvm.org/D69238. Sorry about that. Would you like me to revert both commits and then re-commit with the correct links, etc.? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

lebedev.ri added a comment. In D70165#1750606 , @mitchell-stellar wrote: > Yes, there was a failing unit test that had to be fixed. I reverted the first > commit and then committed a version that fixed the failing test. I mean, the commit message (incl

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar added a comment. Yes, there was a failing unit test that had to be fixed. I reverted the first commit and then committed a version that fixed the failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70165/new/ https://revie

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

lebedev.ri added subscribers: mitchell-stellar, lebedev.ri. lebedev.ri added a comment. @poelmanc @mitchell-stellar I'm confused by the diff - did this land? Was the correct patch committed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70165/new/

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

lebedev.ri added a comment. Ah, so it *really* landed in rG06f3dabe4a2e85a32ade27c0769b6084c828a206 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70165/new/ https://reviews.llv

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

This revision was automatically updated to reflect the committed changes. Closed by commit rG50e99563fb04: [clang-tidy] modernize-use-override new option AllowOverrideAndFinal (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D70165?vs=229012&id=229632

[clang-tools-extra] 50e9956 - [clang-tidy] modernize-use-override new option AllowOverrideAndFinal

.diff LOG: [clang-tidy] modernize-use-override new option AllowOverrideAndFinal Summary: In addition to adding `override` wherever possible, clang-tidy's `modernize-use-override` nicely removes `virtual` when `override` or `final` is specified, and further removes override when final is spec

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

poelmanc added a comment. In D70165#1745530 , @alexfh wrote: > While I have no objections against this patch, I wonder whether someone had a > chance to ask GCC developers about this? Is it a conscious choice to suggest > `override` when `final` is prese

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

alexfh added a comment. While I have no objections against this patch, I wonder whether someone had a chance to ask GCC developers about this? Is it a conscious choice to suggest `override` when `final` is present? What's the argument for doing so? Repository: rCTE Clang Tools Extra CHANGES

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

poelmanc added a comment. In D70165#1744007 , @JonasToth wrote: > LGTM! > Did you check on a real code-base that suffers from the issue, if that works > as expected? Thanks! I have now run it on our real code base and it worked as expected. I lack com

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM! Did you check on a real code-base that suffers from the issue, if that works as expected? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

poelmanc created this revision. poelmanc added reviewers: alexfh, djasper. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. In addition to adding `override` wherever possible, clang-tidy's `modernize-use-override` nicely removes `virtual` when `override` or `final` is

r280828 - [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes.

Author: eugenezelenko Date: Wed Sep 7 12:37:28 2016 New Revision: 280828 URL: http://llvm.org/viewvc/llvm-project?rev=280828&view=rev Log: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes. Differential revision: h

Re: [PATCH] D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL280828: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and… (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24165?vs=70084&id=70564#toc Reposi

[clang-tools-extra] r280741 - [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes.

Author: eugenezelenko Date: Tue Sep 6 14:53:26 2016 New Revision: 280741 URL: http://llvm.org/viewvc/llvm-project?rev=280741&view=rev Log: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes. Differential revision: h

Re: [PATCH] D24179: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL280741: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What… (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24179?vs=70121&id=70459

Re: [PATCH] D24178: [clang-rename] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL280638: [clang-rename] Fix Clang-tidy and IWYU warnings; other minor fixes (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D24178?vs=70119&id=70293#toc Repository: rL LLVM h

Re: [PATCH] D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

sfantao added a comment. Hi Eugene, The patch looks good to me. You may wait for someone that could okay the patch to take a look too. Thanks, Samuel Repository: rL LLVM https://reviews.llvm.org/D24165 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

sfantao added a comment. Hi Eugene, The patch looks good to me. You may wait for someone that could okay the patch to take a look too. Thanks, Samuel Repository: rL LLVM https://reviews.llvm.org/D24165 ___ cfe-commits mailing list cfe-commits@

Re: [PATCH] D24178: [clang-rename] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

omtcyfz accepted this revision. omtcyfz added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D24178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D24179: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM https://reviews.llvm.org/D24179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D24179: [include-fixer] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: hokein. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM https://review

[PATCH] D24178: [clang-rename] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: omtcyf0. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D24178 Files: clang-rename/USRFinder.h Index: clang-re

[PATCH] D24165: [clang-offload-bundler] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: sfantao, compnerd, mehdi_amini. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository:

[clang-tools-extra] r268349 - [Clang-tidy] Fix Clang-tidy modernize-use-override and some Include What You Use warnings in modernize/MakeSmartPtrCheck.h.

Author: eugenezelenko Date: Mon May 2 20:13:27 2016 New Revision: 268349 URL: http://llvm.org/viewvc/llvm-project?rev=268349&view=rev Log: [Clang-tidy] Fix Clang-tidy modernize-use-override and some Include What You Use warnings in modernize/MakeSmartPtrCheck.h. Modified: clang-tools-e

Re: [PATCH] D19755: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL268262: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D19755?vs=55694&id=55849

[clang-tools-extra] r268262 - [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings.

Author: eugenezelenko Date: Mon May 2 12:49:00 2016 New Revision: 268262 URL: http://llvm.org/viewvc/llvm-project?rev=268262&view=rev Log: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings. Differential revision: http://reviews.llvm.org/D1

Re: [PATCH] D19755: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM http://reviews.llvm.org/D19755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D19755: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: bkramer, hokein, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository:

Re: clang-tidy modernize-use-override

2001 > From: Rob > Date: Mon, 21 Mar 2016 12:14:26 + > Subject: [PATCH] modernize-use-override fix for const=0 (without spaces) and > __declspec(dll_export) attributes > > --- > clang-tidy/modernize/UseOverrideCheck.cpp | 17 +++--- > test/clang-tidy/modernize-us

clang-tidy modernize-use-override

Hi, First time poster here, Please advise... Can I contribute these patches for clang-tidy modernize-use-override addressing two problems: 1: missing spaces on pure function decls Orig: void pure() const=0 Problem: void pure() constoverride =0 Fixed: void pure() const override =0 2: This is

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL258870: Fix Clang-tidy modernize-use-override warning in unittests/clang… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D16566?vs=45938&id=46054#toc Repository:

[clang-tools-extra] r258870 - Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes.

Author: eugenezelenko Date: Tue Jan 26 16:32:24 2016 New Revision: 258870 URL: http://llvm.org/viewvc/llvm-project?rev=258870&view=rev Log: Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes. Differential revision:

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

Eugene.Zelenko added inline comments. Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101 @@ -100,3 +100,3 @@ : IncludeInserterCheckBase(CheckName, Context) {} - virtual ~CXXSystemIncludeInserterCheck() {} + ~CXXSystemIncludeInserterCheck() override = default;

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

alexfh added inline comments. Comment at: unittests/clang-tidy/IncludeInserterTest.cpp:101 @@ -100,3 +100,3 @@ : IncludeInserterCheckBase(CheckName, Context) {} - virtual ~CXXSystemIncludeInserterCheck() {} + ~CXXSystemIncludeInserterCheck() override = default;

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

On Mon, Jan 25, 2016 at 6:20 PM, Eugene Zelenko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Eugene.Zelenko created this revision. > Eugene.Zelenko added reviewers: alexfh, aaron.ballman. > Eugene.Zelenko added a subscriber: cfe-commits. > Eugene.Zelenko set the repository for this revis

Re: [PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rL LLVM http://reviews.llvm.org/D16566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D16566: [Clang-tidy] Fix Clang-tidy modernize-use-override warning in unittests/clang-tidy/IncludeInserterTest.cpp; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: alexfh, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM