This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGde29719af2c7: [clang-tools-extra] Document clang tidy unit
tests target (authored by LegalizeAdulthood).
Repository:
rG LLVM Github Monorepo
: [clang-tools-extra] Document clang tidy unit tests target
Differential Revision: https://reviews.llvm.org/D121019
Added:
Modified:
clang-tools-extra/docs/clang-tidy/Contributing.rst
Removed:
diff
tests for the public AST
matcher
classes and is a good source of testing idioms for matchers.
+You can build the Clang-tidy unit tests by building the ``ClangTidyTests``
target.
+Test targets in LLVM and Clang are excluded from the "build all" style action
of
+IDE-based CMake generato
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM!
Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:369
+Test targets in LLVM and Clang are excluded from the "build all" style action
of
+IDE based CMake generators, so you need to explicitl
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:367
+You can build the Clang Tidy unit tests by building the ``ClangTidyTests``
target.
+Test targets in LLVM and Clang are excluded from the "build all" style
-tidy/Contributing.rst
@@ -364,6 +364,11 @@
test. The ``ASTMatchersTests`` target contains unit tests for the public AST
matcher
classes and is a good source of testing idioms for matchers.
+You can build the Clang Tidy unit tests by building the ``ClangTidyTests``
target.
+Test targets in LLVM
On Wed, Sep 2, 2015 at 10:44 AM, Alexander Kornienko wrote:
> Looks like we need to call both ClangTidyContext::setASTContext,
> ClangTidyCheck::registerMatchers and ClangTidyContext::setCurrentFile in
> TestClangTidyAction::CreateASTConsumer. Maybe something else will need to
> move there as well
Looks like we need to call both ClangTidyContext::setASTContext,
ClangTidyCheck::registerMatchers and ClangTidyContext::setCurrentFile
in TestClangTidyAction::CreateASTConsumer. Maybe something else will need
to move there as well.
-- Alex
On Wed, Sep 2, 2015 at 4:09 PM, Aaron Ballman
wrote:
>
I ran into an issue with the runCheckOnCode() function from
clang-tidy's unit tests, and I am not familiar enough with the way
tool invocation works to suggest a correct fix.
ClangTidyContext::setASTContext() is what sets up the language options
for the ClangTidyContext object currently. However,
