Re: r248782 - clang-format: Extend #include sorting functionality

2015-10-19 Thread Daniel Jasper via cfe-commits
Hm, seems to me that this is broken either way. If config.h remains first, that is good, but the main #include is unlikely to remain second. I think we should give the main #include a non-zero #include category and then properly configure config.h to be before that. I'll try to get to that this

Re: r248782 - clang-format: Extend #include sorting functionality

2015-10-19 Thread Nico Weber via cfe-commits
On Mon, Oct 19, 2015 at 4:24 AM, Daniel Jasper wrote: > Hm, seems to me that this is broken either way. If config.h remains first, > that is good, but the main #include is unlikely to remain second. > In practice, the first two lines are a block with two includes: config.h

Re: r248782 - clang-format: Extend #include sorting functionality

2015-10-18 Thread Nico Weber via cfe-commits
On Tue, Sep 29, 2015 at 12:53 AM, Daniel Jasper via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: djasper > Date: Tue Sep 29 02:53:08 2015 > New Revision: 248782 > > URL: http://llvm.org/viewvc/llvm-project?rev=248782=rev > Log: > clang-format: Extend #include sorting functionality >