Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

2016-01-22 Thread Dimitry Andric via cfe-commits
Thanks, I merged it in r258549. -Dimitry > On 22 Jan 2016, at 21:43, Hans Wennborg wrote: > > It seems Richard is out of office, but perhaps he can verify this later. > > Dimitry: go ahead and merge it (or let me know if you'd like me to). > > On Fri, Jan 22, 2016 at 12:38 PM, Dimitry Andric

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

2016-01-22 Thread Hans Wennborg via cfe-commits
It seems Richard is out of office, but perhaps he can verify this later. Dimitry: go ahead and merge it (or let me know if you'd like me to). On Fri, Jan 22, 2016 at 12:38 PM, Dimitry Andric wrote: > Hans, > > This change looks pretty trivial, and is required to not crash for the test > cases i

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

2016-01-22 Thread Dimitry Andric via cfe-commits
Hans, This change looks pretty trivial, and is required to not crash for the test cases in PR26134. Can we merge it to release_38, please? -Dimitry > On 19 Jan 2016, at 19:28, Dimitry Andric via cfe-commits > wrote: > > Hi Richard, > > I am unsure if you are specifically the code owner of

Re: r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

2016-01-19 Thread Dimitry Andric via cfe-commits
Hi Richard, I am unsure if you are specifically the code owner of Sema, but can you please approve this change for the 3.8 branch? -Dimitry > On 19 Jan 2016, at 04:58, Faisal Vali via cfe-commits > wrote: > > Author: faisalv > Date: Mon Jan 18 21:58:55 2016 > New Revision: 258110 > > URL: h

r258110 - Fix PR26134: When substituting into default template arguments, keep CurContext unchanged.

2016-01-18 Thread Faisal Vali via cfe-commits
Author: faisalv Date: Mon Jan 18 21:58:55 2016 New Revision: 258110 URL: http://llvm.org/viewvc/llvm-project?rev=258110&view=rev Log: Fix PR26134: When substituting into default template arguments, keep CurContext unchanged. Or, do not set Sema's CurContext to the template declaration's when su