Re: r262576 - Caught and fixed a typo in r262572.

2016-03-03 Thread Sean Callanan via cfe-commits
Nico, the tests for ASTImporter (currently, test/ASTMerge) are currently set up to do an AST merge and check that certain errors occur. I don’t believe they actually go and code-gen, which would have caught this. I think investing in better ASTImporter testing is a great goal, but right now

Re: r262576 - Caught and fixed a typo in r262572.

2016-03-02 Thread Nico Weber via cfe-commits
Is it possible to test this? On Mar 2, 2016 6:26 PM, "Sean Callanan via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: spyffe > Date: Wed Mar 2 20:22:05 2016 > New Revision: 262576 > > URL: http://llvm.org/viewvc/llvm-project?rev=262576=rev > Log: > Caught and fixed a typo in

r262576 - Caught and fixed a typo in r262572.

2016-03-02 Thread Sean Callanan via cfe-commits
Author: spyffe Date: Wed Mar 2 20:22:05 2016 New Revision: 262576 URL: http://llvm.org/viewvc/llvm-project?rev=262576=rev Log: Caught and fixed a typo in r262572. I should have checked and imported D's in-class initializer. Instead I accidentally used ToField's in-class initializer, which is