r263785 - Make LookupResult movable again.

2016-03-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Fri Mar 18 08:31:00 2016 New Revision: 263785 URL: http://llvm.org/viewvc/llvm-project?rev=263785=rev Log: Make LookupResult movable again. We lost copy semantics in r263730, because it only worked for a few very specific cases. Move semantics don't have this issue. Sadly the

Re: r263785 - Make LookupResult movable again.

2016-03-19 Thread David Blaikie via cfe-commits
On Fri, Mar 18, 2016 at 6:31 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Fri Mar 18 08:31:00 2016 > New Revision: 263785 > > URL: http://llvm.org/viewvc/llvm-project?rev=263785=rev > Log: > Make LookupResult movable again. > This shouldn't've

Re: r263785 - Make LookupResult movable again.

2016-03-19 Thread Benjamin Kramer via cfe-commits
On Fri, Mar 18, 2016 at 5:10 PM, David Blaikie wrote: > > > On Fri, Mar 18, 2016 at 6:31 AM, Benjamin Kramer via cfe-commits > wrote: >> >> Author: d0k >> Date: Fri Mar 18 08:31:00 2016 >> New Revision: 263785 >> >> URL:

Re: r263785 - Make LookupResult movable again.

2016-03-19 Thread David Blaikie via cfe-commits
Also might be marginally tidier if Paths was a unique_ptr, then you wouldn't have to explicitly null it out. I think this is still a pretty subtle thing to allow move or copy support for & perhaps best avoided, or split into the query parameters and the result if we're going to support it. For