Re: r265994 - libclang: fix two memory leaks (PR26292)

2016-04-13 Thread David Blaikie via cfe-commits
Didn't seem to be too invasive - r266222. On Tue, Apr 12, 2016 at 10:54 AM, Hans Wennborg wrote: > While useful, that would require a lot of restructuring, I think. > > This file seems to mostly be dealing with C-style objects; > ExprEvalResult doesn't even have a C++ destructor. I'm not going t

Re: r265994 - libclang: fix two memory leaks (PR26292)

2016-04-12 Thread Hans Wennborg via cfe-commits
While useful, that would require a lot of restructuring, I think. This file seems to mostly be dealing with C-style objects; ExprEvalResult doesn't even have a C++ destructor. I'm not going to dig into that, I just wanted to address this bug that someone reported. - Hans On Tue, Apr 12, 2016 a

Re: r265994 - libclang: fix two memory leaks (PR26292)

2016-04-12 Thread David Blaikie via cfe-commits
Any chance of using unique_ptr, or at least a scoped cleanup device, here? On Mon, Apr 11, 2016 at 1:54 PM, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Mon Apr 11 15:53:59 2016 > New Revision: 265994 > > URL: http://llvm.org/viewvc/llvm-project?rev=26

r265994 - libclang: fix two memory leaks (PR26292)

2016-04-11 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Apr 11 15:53:59 2016 New Revision: 265994 URL: http://llvm.org/viewvc/llvm-project?rev=265994&view=rev Log: libclang: fix two memory leaks (PR26292) Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL: http://llvm.org/viewvc