Re: r275368 - Add C++ dependencies to xray runtime

2016-07-14 Thread Mikael Holmén via cfe-commits
On 07/14/2016 02:10 PM, Dean Michael Berris wrote: Thanks Mikael -- this has been fixed in r275377 (http://reviews.llvm.org/rL275377). Yes, now it compiled. Thank you! /Mikael On Thu, Jul 14, 2016 at 7:30 PM Mikael Holmén mailto:mikael.hol...@ericsson.com>> wrote: Hi, Your commit

Re: r275368 - Add C++ dependencies to xray runtime

2016-07-14 Thread Dean Michael Berris via cfe-commits
Thanks Mikael -- this has been fixed in r275377 ( http://reviews.llvm.org/rL275377). On Thu, Jul 14, 2016 at 7:30 PM Mikael Holmén wrote: > Hi, > > Your commit > > Add C++ dependencies to xray runtime > > Doesn't compile with gcc. At least 5.3 and 4.8.4 complains about this > change: > > +

Re: r275368 - Add C++ dependencies to xray runtime

2016-07-14 Thread Mikael Holmén via cfe-commits
Hi, Your commit Add C++ dependencies to xray runtime Doesn't compile with gcc. At least 5.3 and 4.8.4 complains about this change: + if (Args.hasArg(options::OPT_fxray_instrument, + options::OPT_fnoxray_instrument, false)) { +CmdArgs.push_back("-fxray-instrument");

r275368 - Add C++ dependencies to xray runtime

2016-07-13 Thread Dean Michael Berris via cfe-commits
Author: dberris Date: Wed Jul 13 23:58:44 2016 New Revision: 275368 URL: http://llvm.org/viewvc/llvm-project?rev=275368&view=rev Log: Add C++ dependencies to xray runtime Summary: Depends on D21982 which implements the in-memory logging implementation of the XRay runtime. These additional changes