Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-19 Thread Vassil Vassilev via cfe-commits
I totally misinterpreted this revert. I was confused it reverted r284284. Sorry for the noise. With the fix introduced in r284577 our bots should be happy. On 19/10/16 09:50, Vassil Vassilev wrote: On 17/10/16 17:07, Benjamin Kramer wrote: I'm running into something else and your patch doesn'

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-19 Thread Vassil Vassilev via cfe-commits
On 17/10/16 17:07, Benjamin Kramer wrote: I'm running into something else and your patch doesn't fix it. It boils down to 'std::is_nothrow_move_constructible' from libstdc++ not compiling because Foo is not visible inside the noexcept specification of that template. I failed to come up with a sm

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Benjamin Kramer via cfe-commits
I'm running into something else and your patch doesn't fix it. It boils down to 'std::is_nothrow_move_constructible' from libstdc++ not compiling because Foo is not visible inside the noexcept specification of that template. I failed to come up with a small test case so far as it involves at least

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Vassil Vassilev via cfe-commits
On 17/10/16 16:40, Benjamin Kramer wrote: Too slow ;) Do you have the fix somewhere, so I can try it? That would be https://reviews.llvm.org/D25678 Do you run into something else than what I have as a test case (merging templated constexpr variables)? On Mon, Oct 17, 2016 at 4:38 PM, Vassil

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Benjamin Kramer via cfe-commits
Too slow ;) Do you have the fix somewhere, so I can try it? On Mon, Oct 17, 2016 at 4:38 PM, Vassil Vassilev wrote: > I was just to commit a fix :( > > On 17/10/16 15:00, Benjamin Kramer via cfe-commits wrote: >> >> Author: d0k >> Date: Mon Oct 17 08:00:44 2016 >> New Revision: 284382 >> >> URL:

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Vassil Vassilev via cfe-commits
I was just to commit a fix :( On 17/10/16 15:00, Benjamin Kramer via cfe-commits wrote: Author: d0k Date: Mon Oct 17 08:00:44 2016 New Revision: 284382 URL: http://llvm.org/viewvc/llvm-project?rev=284382&view=rev Log: Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling

r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

2016-10-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Oct 17 08:00:44 2016 New Revision: 284382 URL: http://llvm.org/viewvc/llvm-project?rev=284382&view=rev Log: Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of" This reverts commit r284176. It still marks some modules as invisible that should b