Re: r296166 - clang-format: Don't leave behind temp files in -i mode on Windows, PR26125

2017-02-25 Thread NAKAMURA Takumi via cfe-commits
Reverted in r296237 . (MemoryBuffer)Code is referred after Code.reset(). On Sun, Feb 26, 2017 at 12:40 AM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Thanks, I had fixed this in 171 a bit over an hour before your mail. > > On Feb 24, 2017 5:17 PM, "Renato Golin via

Re: r296166 - clang-format: Don't leave behind temp files in -i mode on Windows, PR26125

2017-02-25 Thread Nico Weber via cfe-commits
Thanks, I had fixed this in 171 a bit over an hour before your mail. On Feb 24, 2017 5:17 PM, "Renato Golin via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > On 24 February 2017 at 20:49, Nico Weber via cfe-commits > wrote: > > Author: nico > > Date: Fri Feb 24

r296237 - Revert r296166, "clang-format: Don't leave behind temp files in -i mode on Windows, PR26125", and r296171.

2017-02-24 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Fri Feb 24 21:45:49 2017 New Revision: 296237 URL: http://llvm.org/viewvc/llvm-project?rev=296237=rev Log: Revert r296166, "clang-format: Don't leave behind temp files in -i mode on Windows, PR26125", and r296171. (MemoryBuffer)Code.reset() was too early.

Re: r296166 - clang-format: Don't leave behind temp files in -i mode on Windows, PR26125

2017-02-24 Thread Renato Golin via cfe-commits
On 24 February 2017 at 20:49, Nico Weber via cfe-commits wrote: > Author: nico > Date: Fri Feb 24 14:49:00 2017 > New Revision: 296166 > > URL: http://llvm.org/viewvc/llvm-project?rev=296166=rev > Log: > clang-format: Don't leave behind temp files in -i mode on

r296166 - clang-format: Don't leave behind temp files in -i mode on Windows, PR26125

2017-02-24 Thread Nico Weber via cfe-commits
Author: nico Date: Fri Feb 24 14:49:00 2017 New Revision: 296166 URL: http://llvm.org/viewvc/llvm-project?rev=296166=rev Log: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125 Fix and analysis by Wei Mao (see bug), test by me. Added: