Author: rogfer01 Date: Mon Mar 13 08:18:21 2017 New Revision: 297620 URL: http://llvm.org/viewvc/llvm-project?rev=297620&view=rev Log: When diagnosing taking address of packed members skip __unaligned-qualified expressions
Given that we have already explicitly stated in the qualifier that the expression is __unaligned, it makes little sense to diagnose that the address of the packed member may not be aligned. Differential Revision: https://reviews.llvm.org/D30884 Added: cfe/trunk/test/Sema/address-unaligned.c Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified: cfe/trunk/lib/Sema/SemaChecking.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=297620&r1=297619&r2=297620&view=diff ============================================================================== --- cfe/trunk/lib/Sema/SemaChecking.cpp (original) +++ cfe/trunk/lib/Sema/SemaChecking.cpp Mon Mar 13 08:18:21 2017 @@ -11851,6 +11851,10 @@ void Sema::RefersToMemberWithReducedAlig if (!ME) return; + // No need to check expressions with an __unaligned-qualified type. + if (E->getType().getQualifiers().hasUnaligned()) + return; + // For a chain of MemberExpr like "a.b.c.d" this list // will keep FieldDecl's like [d, c, b]. SmallVector<FieldDecl *, 4> ReverseMemberChain; Added: cfe/trunk/test/Sema/address-unaligned.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/address-unaligned.c?rev=297620&view=auto ============================================================================== --- cfe/trunk/test/Sema/address-unaligned.c (added) +++ cfe/trunk/test/Sema/address-unaligned.c Mon Mar 13 08:18:21 2017 @@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -fsyntax-only -fms-extensions -verify %s +// expected-no-diagnostics + +typedef +struct __attribute__((packed)) S1 { + char c0; + int x; + char c1; +} S1; + +void bar(__unaligned int *); + +void foo(__unaligned S1* s1) +{ + bar(&s1->x); +} _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits