Re: r297890 - enable -save-temps with -finclude-defult-header

2017-03-16 Thread Guansong Zhang via cfe-commits
Many thanks! Regards Guansong On Wed, Mar 15, 2017 at 7:55 PM, Eric Christopher wrote: > Hi Guansong, > > So this wasn't quite the right way to write this testcase. You really > wanted a CHECK/CHECK-NOT line along with the actual commands. You also > didn't want to (as you

Re: r297890 - enable -save-temps with -finclude-defult-header

2017-03-15 Thread Eric Christopher via cfe-commits
Hi Guansong, So this wasn't quite the right way to write this testcase. You really wanted a CHECK/CHECK-NOT line along with the actual commands. You also didn't want to (as you noticed later) depend on full compilation. You can check for this sort of thing in the future by using the -### command

r297890 - enable -save-temps with -finclude-defult-header

2017-03-15 Thread Guansong Zhang via cfe-commits
Author: guansong Date: Wed Mar 15 15:57:11 2017 New Revision: 297890 URL: http://llvm.org/viewvc/llvm-project?rev=297890=rev Log: enable -save-temps with -finclude-defult-header Currently the two flags can not work together. To illustrate the issue, we can have an one line file a.cl contains