Re: r298676 - Fix handling of initialization from parenthesized initializer list.

2017-03-27 Thread Daniel Jasper via cfe-commits
-Wunused-value is always triggered if a constructor of an object with a non-trivial destructor has an initializer list as first parameter. So in the test, even "Used({});" triggers -Wunused-value. That seems inconsistent (replacing the init list with something else silences the warning) and also

Re: r298676 - Fix handling of initialization from parenthesized initializer list.

2017-03-27 Thread Richard Smith via cfe-commits
What is the effect on that testcase? (Sorry, heading to vacation and can't easily check.) On 27 Mar 2017 6:33 am, "Daniel Jasper" wrote: > Hi Richard, > > this seems to have an unwanted side-effect on -Wunused-value (test case > attached). Could you take a look? > > Cheers,

Re: r298676 - Fix handling of initialization from parenthesized initializer list.

2017-03-27 Thread Daniel Jasper via cfe-commits
Hi Richard, this seems to have an unwanted side-effect on -Wunused-value (test case attached). Could you take a look? Cheers, Daniel On Fri, Mar 24, 2017 at 2:14 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Mar 23 20:14:25 2017 > New

r298676 - Fix handling of initialization from parenthesized initializer list.

2017-03-23 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Mar 23 20:14:25 2017 New Revision: 298676 URL: http://llvm.org/viewvc/llvm-project?rev=298676=rev Log: Fix handling of initialization from parenthesized initializer list. This change fixes a crash on initialization of a reference from ({}) during template instantiation