Re: r301470 - Fix API breaks

2017-04-26 Thread David Blaikie via cfe-commits
On Wed, Apr 26, 2017 at 2:18 PM Vedant Kumar wrote: > > > On Apr 26, 2017, at 2:16 PM, David Blaikie wrote: > > > > Sorry about that - thought I synced up moments before the commit. > > No worries, it's an innocent race. > > > > Stuff like this is generally easier to fix forward, imho. Though th

Re: r301470 - Fix API breaks

2017-04-26 Thread Vedant Kumar via cfe-commits
> On Apr 26, 2017, at 2:16 PM, David Blaikie wrote: > > Sorry about that - thought I synced up moments before the commit. No worries, it's an innocent race. > Stuff like this is generally easier to fix forward, imho. Though the fact > that this wouldn't've compiled without the changes does p

Re: r301470 - Fix API breaks

2017-04-26 Thread David Blaikie via cfe-commits
Sorry about that - thought I synced up moments before the commit. Stuff like this is generally easier to fix forward, imho. Though the fact that this wouldn't've compiled without the changes does provide some misgivings about the quality of the patch (but I've certainly committed some things as sh

Re: r301470 - Fix API breaks

2017-04-26 Thread Vedant Kumar via cfe-commits
Hi David, It looks like this conflicts with my revert. I will revert my revert, since this seems like it fixes things. vedant > On Apr 26, 2017, at 1:58 PM, David Blaikie via cfe-commits > wrote: > > Author: dblaikie > Date: Wed Apr 26 15:58:21 2017 > New Revision: 301470 > > URL: http://ll

r301470 - Fix API breaks

2017-04-26 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Wed Apr 26 15:58:21 2017 New Revision: 301470 URL: http://llvm.org/viewvc/llvm-project?rev=301470&view=rev Log: Fix API breaks Modified: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp cfe/trunk/lib/CodeGen/MacroPPCallbacks.h Modified: cfe/trunk/lib/CodeGen/MacroPPCallb