Re: r304956 - [ODRHash] Change the fall-back diagnostic error.

2017-06-07 Thread Richard Trieu via cfe-commits
After r304962, it should now produce messages like: 'foo' defined here has different definitions in different modules; first difference is this unexpected decl but in 'Module' found another unexpected decl 'foo' with definition in module 'FirstModule' has different definitions in different

Re: r304956 - [ODRHash] Change the fall-back diagnostic error.

2017-06-07 Thread Richard Trieu via cfe-commits
Yes, I will go correct the diagnostic text. In theory, there is nothing that is supposed to reach this diagnostic or the one below it. Except that the hasher isn't complete yet and some things slip through. Once things are more stable, these should be replaced with llvm_unreachable instead. On

Re: r304956 - [ODRHash] Change the fall-back diagnostic error.

2017-06-07 Thread Richard Smith via cfe-commits
On 7 June 2017 at 17:56, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Wed Jun 7 19:56:21 2017 > New Revision: 304956 > > URL: http://llvm.org/viewvc/llvm-project?rev=304956=rev > Log: > [ODRHash] Change the fall-back diagnostic error. > > Provide a

r304956 - [ODRHash] Change the fall-back diagnostic error.

2017-06-07 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Wed Jun 7 19:56:21 2017 New Revision: 304956 URL: http://llvm.org/viewvc/llvm-project?rev=304956=rev Log: [ODRHash] Change the fall-back diagnostic error. Provide a little more information when a ODR violation is detected, but the specific error could not be diagnosed.