Re: r305110 - [ODRHash] Add support for TemplateArgument types.

2017-12-10 Thread Vassil Vassilev via cfe-commits
On 12/8/17 9:14 PM, Richard Trieu wrote: Vassil, It depends on which parts of the AST you want to be stable.  The ODRHashing is stable across TU's, but it may depend on information that you don't want to be part of the hash.  For instance, if you have "using F = float;" in you code, then the

Re: r305110 - [ODRHash] Add support for TemplateArgument types.

2017-12-08 Thread Richard Trieu via cfe-commits
Vassil, It depends on which parts of the AST you want to be stable. The ODRHashing is stable across TU's, but it may depend on information that you don't want to be part of the hash. For instance, if you have "using F = float;" in you code, then the hash of TemplateArgument for "float" and for

Re: r305110 - [ODRHash] Add support for TemplateArgument types.

2017-12-08 Thread Vassil Vassilev via cfe-commits
Hi Richard,   Is there a way to get an ODRHashing which is stable across translation units? I'd like to use the TemplateArgument ODRHash to lookup template specializations and deserialize them only if they are required. Many thanks! Vassil On 6/9/17 11:00 PM, Richard Trieu via cfe-commits

Re: r305110 - [ODRHash] Add support for TemplateArgument types.

2017-06-09 Thread Richard Smith via cfe-commits
Could this failure be due to your change: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/8365/steps/compile.llvm.stage2/logs/stdio ? On 9 June 2017 at 14:00, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Fri Jun 9

r305110 - [ODRHash] Add support for TemplateArgument types.

2017-06-09 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Fri Jun 9 16:00:10 2017 New Revision: 305110 URL: http://llvm.org/viewvc/llvm-project?rev=305110=rev Log: [ODRHash] Add support for TemplateArgument types. Recommit r304592 that was reverted in r304618. r305104 should have fixed the issue. Modified: