Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

2021-11-01 Thread David Blaikie via cfe-commits
Ping On Tue, Sep 21, 2021 at 7:58 PM David Blaikie wrote: > Ping > > On Sun, Sep 5, 2021 at 11:28 AM David Blaikie wrote: > >> Hey Richard - was just going back over some of the modular codegen code >> (due to a discussion on the EWG mailing list about file extensions that >> ended up touching

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

2021-09-21 Thread David Blaikie via cfe-commits
Ping On Sun, Sep 5, 2021 at 11:28 AM David Blaikie wrote: > Hey Richard - was just going back over some of the modular codegen code > (due to a discussion on the EWG mailing list about file extensions that > ended up touching on the nature of how modules are built) - and I came > across this cod

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

2021-09-05 Thread David Blaikie via cfe-commits
Hey Richard - was just going back over some of the modular codegen code (due to a discussion on the EWG mailing list about file extensions that ended up touching on the nature of how modules are built) - and I came across this code & had the same question I see I wrote up here already but got lost

Re: r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

2017-07-16 Thread David Blaikie via cfe-commits
Looks good - does this support available_externally definitions of strong external linkage functions in the users of a module? (is that tested?) Should it? Also should we consider having two flags for modular codegen - one for correctness (external function definitions), one for linkage size optim

r307232 - [modules ts] Do not emit strong function definitions from the module interface unit in every user.

2017-07-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jul 5 17:30:00 2017 New Revision: 307232 URL: http://llvm.org/viewvc/llvm-project?rev=307232&view=rev Log: [modules ts] Do not emit strong function definitions from the module interface unit in every user. Added: cfe/trunk/test/CXX/modules-ts/basic/basic.def.odr/