Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

2017-08-30 Thread Adrian Prantl via cfe-commits
Reduced in r312175. -- adrian > On Aug 28, 2017, at 4:47 PM, David Blaikie wrote: > > *nod* Thanks - let me know if you have trouble simplifying or explaining it & > I'll see if fresh eyes help :) > > On Mon, Aug 28, 2017 at 4:46 PM Adrian Prantl wrote: > It's possible that this testcase ca

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

2017-08-28 Thread David Blaikie via cfe-commits
*nod* Thanks - let me know if you have trouble simplifying or explaining it & I'll see if fresh eyes help :) On Mon, Aug 28, 2017 at 4:46 PM Adrian Prantl wrote: > It's possible that this testcase can be golfed some more. I copied it > almost verbatim from the PR. I'll see what I can do. The imp

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

2017-08-28 Thread Adrian Prantl via cfe-commits
It's possible that this testcase can be golfed some more. I copied it almost verbatim from the PR. I'll see what I can do. The important thing is that it needs to trigger the situation where the frontend is creating an inlined function. -- adrian > On Aug 28, 2017, at 4:43 PM, David Blaikie wr

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

2017-08-28 Thread David Blaikie via cfe-commits
Seems like a rather complex test case - could you explain what's going on there? (maybe in the form of a comment in the code - what path through all those classes is required to tickle this) On Wed, Aug 23, 2017 at 2:25 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Autho

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

2017-08-24 Thread Hans Wennborg via cfe-commits
Merged to 5.0 in r311671. On Wed, Aug 23, 2017 at 2:24 PM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Wed Aug 23 14:24:12 2017 > New Revision: 311601 > > URL: http://llvm.org/viewvc/llvm-project?rev=311601&view=rev > Log: > Fix a bug in CGDebugInfo::EmitInlineFunctionStart caus

r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

2017-08-23 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Wed Aug 23 14:24:12 2017 New Revision: 311601 URL: http://llvm.org/viewvc/llvm-project?rev=311601&view=rev Log: Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be parented in function declarations. Fixes PR33997. https://bugs.llvm.org/show_bug.cgi?id=