Re: r319727 - Generalize "static data member instantiated" notification to cover variable templates too.

Should be fixed in r319835. I'd forgotten that Darwin / MachO uses a different mechanism from COMDATs here. On 5 December 2017 at 13:27, Ahmed Bougacha via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Dec 5, 2017 at 11:40 AM, Richard Smith via cfe-commits >

Re: r319727 - Generalize "static data member instantiated" notification to cover variable templates too.

On Tue, Dec 5, 2017 at 11:40 AM, Richard Smith via cfe-commits wrote: > Sorry about that, fixed in r319817. Hey Richard, Looks like that's not enough on darwin:

Re: r319727 - Generalize "static data member instantiated" notification to cover variable templates too.

Sorry about that, fixed in r319817. On 5 December 2017 at 10:38, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke tests on one of our bots: > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64- > expensive-checks-win/builds/6568 > >

Re: r319727 - Generalize "static data member instantiated" notification to cover variable templates too.

Hello Richard, This commit broke tests on one of our bots: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6568 Failing Tests (3): . . . Clang :: Modules/var-templates.cpp . . . Please have a look? Thanks Galina On Mon, Dec 4, 2017 at 5:31 PM, Richard

r319727 - Generalize "static data member instantiated" notification to cover variable templates too.

Author: rsmith Date: Mon Dec 4 17:31:47 2017 New Revision: 319727 URL: http://llvm.org/viewvc/llvm-project?rev=319727=rev Log: Generalize "static data member instantiated" notification to cover variable templates too. While here, split the "point of instantiation changed" notification out from