I committed the patch that allows -m-version-min to specify the OS
version when -target doesn't specify in r321559. Let me know if it works
for you!
Thanks,
Alex
On 21 December 2017 at 12:34, James Y Knight wrote:
> I totally agree with moving towards eliminating the -m-version-min
> flags, it'
> On Dec 21, 2017, at 16:39, Alex L wrote:
>
>
>
>> On 21 December 2017 at 12:34, James Y Knight wrote:
>> I totally agree with moving towards eliminating the -m-version-min
>> flags, it's much better to put it in the target, and will clean up a lot of
>> cruft in the driver, eventually.
>>
On 21 December 2017 at 12:34, James Y Knight wrote:
> I totally agree with moving towards eliminating the -m-version-min
> flags, it's much better to put it in the target, and will clean up a lot of
> cruft in the driver, eventually.
>
> Now -- we (or anyone else who runs into this) can simply st
I totally agree with moving towards eliminating the -m-version-min
flags, it's much better to put it in the target, and will clean up a lot of
cruft in the driver, eventually.
Now -- we (or anyone else who runs into this) can simply start specifying
the version in both locations ("-target x86_64-a
Thanks for the quick response and your suggestions!
I believe the workaround you suggest in 1) will work for us, so there's no
need for an urgent change. Thanks again!
On 21 December 2017 at 20:11, Alex L wrote:
> Thanks for raising your concerns.
>
> We decided to avoid -m-version-min flag in
Thanks for raising your concerns.
We decided to avoid -m-version-min flag in favor of -target to simplify
the driver logic and to encourage the adoption of -target. Now after r321145
we only warn about -m-version-min flag when the OS version specified in
it is different to the OS version specified
I think if a version number isn't explicitly specified in the -target
value, the value from -m-version-min ought to still be used, as
it was before.
Currently, clang will ignore the -m-version-min version number if
the target has a particular OS specified, even if it has no version number
as part
This is causing problems in some internal builds that specify both
-mios-simulator-version-min=9.0 and --target=x86_64-apple-ios
My expectation would be for the code to take the minimum OS version number
from the -mios-simulator-version-min flag. In fact, however, the code seems
to be completely i
Author: arphaman
Date: Tue Dec 19 11:05:04 2017
New Revision: 321099
URL: http://llvm.org/viewvc/llvm-project?rev=321099&view=rev
Log:
[driver][darwin] Take the OS version specified in "-target" as the target
OS instead of inferring it from SDK / environment
The OS version is specified in -target