Re: r322813 - Fix Scope::dump()

2018-01-22 Thread Hans Wennborg via cfe-commits
Thanks! r323109. On Sat, Jan 20, 2018 at 12:53 AM, Richard Smith wrote: > Sounds like a good idea to me. > > On 19 Jan 2018 15:23, "Richard Trieu via cfe-commits" > wrote: >> >> Hans, >> >> I recommend merging this revision into the release.

Re: r322813 - Fix Scope::dump()

2018-01-19 Thread Richard Smith via cfe-commits
Sounds like a good idea to me. On 19 Jan 2018 15:23, "Richard Trieu via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Hans, > > I recommend merging this revision into the release. It fixes an infinite > loop in Scope::dump() > > Richard > > On Wed, Jan 17, 2018 at 8:28 PM, Richard Trieu

Re: r322813 - Fix Scope::dump()

2018-01-19 Thread Richard Trieu via cfe-commits
Hans, I recommend merging this revision into the release. It fixes an infinite loop in Scope::dump() Richard On Wed, Jan 17, 2018 at 8:28 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Wed Jan 17 20:28:56 2018 > New Revision: 322813 > > URL:

r322813 - Fix Scope::dump()

2018-01-17 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Wed Jan 17 20:28:56 2018 New Revision: 322813 URL: http://llvm.org/viewvc/llvm-project?rev=322813=rev Log: Fix Scope::dump() The dump function for Scope only has 20 out of the 24 flags. Since it looped until no flags were left, having an unknown flag lead to an infinite