Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

2018-03-28 Thread Alexander Kornienko via cfe-commits
It looks like it was fixed, indeed. After an update I don't see an awful number of crashes any more. Thanks! On Mon, Mar 26, 2018 at 8:05 PM George Karpenkov wrote: > Yeah, I’m pretty sure this was fixed on Friday with > https://reviews.llvm.org/rC328406 > > On Mar 26, 2018, at 10:54 AM, Alexan

Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

2018-03-26 Thread George Karpenkov via cfe-commits
Yeah, I’m pretty sure this was fixed on Friday with https://reviews.llvm.org/rC328406 > On Mar 26, 2018, at 10:54 AM, Alexander Kornienko wrote: > > This checker crashes on almost each file in our codebase. No test case yet, > but here's a stack trace: > clang::Type::getTypeClass > clang::Refe

Re: r328282 - [analyzer] Trust _Nonnull annotations for system framework

2018-03-26 Thread Alexander Kornienko via cfe-commits
This checker crashes on almost each file in our codebase. No test case yet, but here's a stack trace: clang::Type::getTypeClass clang::ReferenceType::classof llvm::isa_impl::doit llvm::isa_impl_cl::doit llvm::isa_impl_wrap::doit llvm::isa_impl_wrap::doit llvm::isa clang::Type::getAs clang::ASTConte

r328282 - [analyzer] Trust _Nonnull annotations for system framework

2018-03-22 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Thu Mar 22 17:16:03 2018 New Revision: 328282 URL: http://llvm.org/viewvc/llvm-project?rev=328282&view=rev Log: [analyzer] Trust _Nonnull annotations for system framework Changes the analyzer to believe that methods annotated with _Nonnull from system frameworks ind