Re: r332458 - [AST] Added a helper to extract a user-friendly text of a comment.

2018-05-17 Thread Ilya Biryukov via cfe-commits
Terribly sorry for the breakage and many thanks for fixing this! On Thu, May 17, 2018 at 9:04 AM Clement Courbet wrote: > I should have fixed it in r332576. > > On Wed, May 16, 2018 at 11:49 PM, Galina Kistanova via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >>

Re: r332458 - [AST] Added a helper to extract a user-friendly text of a comment.

2018-05-17 Thread Clement Courbet via cfe-commits
I should have fixed it in r332576. On Wed, May 16, 2018 at 11:49 PM, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Also few other builders are affected: > > http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test >

Re: r332458 - [AST] Added a helper to extract a user-friendly text of a comment.

2018-05-16 Thread Galina Kistanova via cfe-commits
Also few other builders are affected: http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test http://lab.llvm.org:8011/builders/clang-lld-x86_64-2stage http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu Thanks Galina On Wed, May 16, 2018 at 12:58 PM, Galina Kistanova

Re: r332458 - [AST] Added a helper to extract a user-friendly text of a comment.

2018-05-16 Thread Galina Kistanova via cfe-commits
Hello Ilya, This commit broke build step for couple of our builders: http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/8541 http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu . . . FAILED: tools/clang/unittests/AST/CMakeFiles/ASTTests.dir/CommentTextTest.cpp.o

r332458 - [AST] Added a helper to extract a user-friendly text of a comment.

2018-05-16 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Wed May 16 05:30:09 2018 New Revision: 332458 URL: http://llvm.org/viewvc/llvm-project?rev=332458=rev Log: [AST] Added a helper to extract a user-friendly text of a comment. Summary: The helper is used in clangd for documentation shown in code completion and storing the