Re: r334494 - Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit internal shell now"

2018-06-13 Thread Hans Wennborg via cfe-commits
The bot turned green: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10234 On Wed, Jun 13, 2018 at 8:54 AM, Hans Wennborg wrote: > As a near term fix, I've tried to shorten the path in r334574. Let's > see if the bot likes it. > > On Wed, Jun 13, 2018 at 6:34 AM,

Re: r334494 - Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit internal shell now"

2018-06-12 Thread Hans Wennborg via cfe-commits
As a near term fix, I've tried to shorten the path in r334574. Let's see if the bot likes it. On Wed, Jun 13, 2018 at 6:34 AM, Galina Kistanova via cfe-commits wrote: > That could be the case. However, the bot shall not be left red. > > Hans, could you revert the patch for now, till the problem w

Re: r334494 - Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit internal shell now"

2018-06-12 Thread Galina Kistanova via cfe-commits
That could be the case. However, the bot shall not be left red. Hans, could you revert the patch for now, till the problem would be addressed on all the Windows bots one way or another, please? I can take a look at my bots later this week. Thanks Galina On Tue, Jun 12, 2018 at 1:52 PM, Reid Kle

Re: r334494 - Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit internal shell now"

2018-06-12 Thread Reid Kleckner via cfe-commits
The length of that path is about 257, or very near MAX_PATH, which suggests that the version of rm you are using does not tolerate deep paths. This has been a long standing problem, and our solution to it was to install a special version of rm.exe on all of our buildbots that reliably handles long

Re: r334494 - Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit internal shell now"

2018-06-12 Thread Galina Kistanova via cfe-commits
Hello Hans, The test Driver/crash-report-modules.m still fails on one of windows builder: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/10221 . . . Failing Tests (1): Clang :: Driver/crash-report-modules.m Please have a look? Thanks Galina On Tue, Jun

r334494 - Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit internal shell now"

2018-06-12 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Jun 12 04:51:22 2018 New Revision: 334494 URL: http://llvm.org/viewvc/llvm-project?rev=334494&view=rev Log: Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit internal shell now" Plus change run lines from not env FOO=bar %clang to env F