RE: r334650 - Implement constexpr __builtin_*_overflow

2018-07-05 Thread Keane, Erich via cfe-commits
Fixed in R336364. Thank you very much for the heads up! From: Evgenii Stepanov [mailto:eugeni.stepa...@gmail.com] Sent: Tuesday, July 3, 2018 12:59 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r334650 - Implement constexpr __builtin_*_overflow Hi, with this change, the following compiles

RE: r334650 - Implement constexpr __builtin_*_overflow

2018-07-03 Thread Keane, Erich via cfe-commits
Yikes! Thanks for the heads up! I’ll start looking into this. Thanks for letting me know. From: Evgenii Stepanov [mailto:eugeni.stepa...@gmail.com] Sent: Tuesday, July 3, 2018 12:59 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r334650 - Implement constexpr __builtin_*_overflow Hi

Re: r334650 - Implement constexpr __builtin_*_overflow

2018-07-03 Thread Evgenii Stepanov via cfe-commits
Discovered by MemorySanitizer, btw. On Tue, Jul 3, 2018 at 12:59 PM, Evgenii Stepanov wrote: > Hi, > > with this change, the following compiles to "ret i32 undef": > > int main(int argc, char **argv) { > > constexpr int x = 1; > > constexpr int y = 2; > > int z; > > > >

Re: r334650 - Implement constexpr __builtin_*_overflow

2018-07-03 Thread Evgenii Stepanov via cfe-commits
Hi, with this change, the following compiles to "ret i32 undef": int main(int argc, char **argv) { constexpr int x = 1; constexpr int y = 2; int z; __builtin_sadd_overflow(x, y, ); return z; } On Wed, Jun 13, 2018 at 1:43 PM, Erich Keane via cfe-commits <

r334650 - Implement constexpr __builtin_*_overflow

2018-06-13 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Wed Jun 13 13:43:27 2018 New Revision: 334650 URL: http://llvm.org/viewvc/llvm-project?rev=334650=rev Log: Implement constexpr __builtin_*_overflow As requested here:https://bugs.llvm.org/show_bug.cgi?id=37633 permit the __builtin_*_overflow builtins in constexpr