Re: r337928 - [OPENMP] Fix PR38256: Fix locations of the artificial conditional op.

2018-07-25 Thread Vedant Kumar via cfe-commits
Ah, great. Thanks again! vedant > On Jul 25, 2018, at 10:33 AM, Alexey Bataev wrote: > > This is visible to the user, the statement under #pragma omp parallel > directive is outlined as a function. > - > Best regards, > Alexey Bataev > 25.07.2018 13:31, Vedant Kumar пишет: >> Thank

Re: r337928 - [OPENMP] Fix PR38256: Fix locations of the artificial conditional op.

2018-07-25 Thread Vedant Kumar via cfe-commits
Thanks! Just out of curiosity, what is the "omp_outlined" function you're checking for? Is it implicitly-defined? If it's not user-visible, i.e it doesn't actually appear in the source code of a program, why should we generate a code coverage mapping for it at all? vedant > On Jul 25, 2018, a

r337928 - [OPENMP] Fix PR38256: Fix locations of the artificial conditional op.

2018-07-25 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Wed Jul 25 07:40:26 2018 New Revision: 337928 URL: http://llvm.org/viewvc/llvm-project?rev=337928&view=rev Log: [OPENMP] Fix PR38256: Fix locations of the artificial conditional op. Fixed the source locations of the conditional op so that they don'r crash coverage pass. Add