Re: r338467 - Avoid exposing name for range-based for '__range' variables in lifetime warnings.

2018-08-07 Thread Richard Smith via cfe-commits
There's definitely scope for improving this diagnostic text further. Right now I don't think there's an easy way to figure out that the variable is the range variable in a range-based for loop, but I think that case is common enough that that's the level of special-case we should be looking at here

Re: r338467 - Avoid exposing name for range-based for '__range' variables in lifetime warnings.

2018-08-07 Thread David Blaikie via cfe-commits
Reckon there's a chance of improved diagnostic text in cases like this? Will users understand what the problem is/how to fix it when they read "temporary implicitly bound to local reference will be destroyed at the end of the full-expression" - feels very standard-ese-y to me? & I appreciate teh de

r338467 - Avoid exposing name for range-based for '__range' variables in lifetime warnings.

2018-07-31 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jul 31 18:03:33 2018 New Revision: 338467 URL: http://llvm.org/viewvc/llvm-project?rev=338467&view=rev Log: Avoid exposing name for range-based for '__range' variables in lifetime warnings. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/