Re: r338732 - [analyzer] Make RegionVector use const reference

2018-08-07 Thread Fangrui Song via cfe-commits
On 2018-08-07, David Blaikie wrote: Looks good! Though it may be useful in the future to describe, in the commit message, the motivation for a change - how'd you find this? What motivated you to make this particular fix just now, etc? ("identified using clang-tidy" or "spotted during post-commit

Re: r338732 - [analyzer] Make RegionVector use const reference

2018-08-07 Thread David Blaikie via cfe-commits
Looks good! Though it may be useful in the future to describe, in the commit message, the motivation for a change - how'd you find this? What motivated you to make this particular fix just now, etc? ("identified using clang-tidy" or "spotted during post-commit review of change r", etc...) On

r338732 - [analyzer] Make RegionVector use const reference

2018-08-02 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Aug 2 09:29:36 2018 New Revision: 338732 URL: http://llvm.org/viewvc/llvm-project?rev=338732=rev Log: [analyzer] Make RegionVector use const reference Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Modified: