Re: r341117 - [MS ABI] Fix mangling issue with dynamic initializer stubs.

2018-08-31 Thread Galina Kistanova via cfe-commits
The builder is just fixed, so I am wrong. Sorry to bother you. Thanks Galina On Fri, Aug 31, 2018 at 1:08 PM Zachary Turner wrote: > Are we sure it was my commit? Because this seems like a very unusual > failure given the nature of the commit. I'll try to reproduce it locally > and report

Re: r341117 - [MS ABI] Fix mangling issue with dynamic initializer stubs.

2018-08-31 Thread Zachary Turner via cfe-commits
It looks like tnorthover has fixed these in r341240 On Fri, Aug 31, 2018 at 1:08 PM Zachary Turner wrote: > Are we sure it was my commit? Because this seems like a very unusual > failure given the nature of the commit. I'll try to reproduce it locally > and report back. > > On Fri, Aug 31,

Re: r341117 - [MS ABI] Fix mangling issue with dynamic initializer stubs.

2018-08-31 Thread Zachary Turner via cfe-commits
Are we sure it was my commit? Because this seems like a very unusual failure given the nature of the commit. I'll try to reproduce it locally and report back. On Fri, Aug 31, 2018 at 11:49 AM Galina Kistanova wrote: > Hello Zachary, > > It looks like this commit added broken tests on one of

Re: r341117 - [MS ABI] Fix mangling issue with dynamic initializer stubs.

2018-08-31 Thread Galina Kistanova via cfe-commits
Hello Zachary, It looks like this commit added broken tests on one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/19508 . . . Failing Tests (2): LLVM-Unit :: ADT/./ADTTests.exe/HashingTest.HashCombineRangeGoldenTest Clang ::

r341117 - [MS ABI] Fix mangling issue with dynamic initializer stubs.

2018-08-30 Thread Zachary Turner via cfe-commits
Author: zturner Date: Thu Aug 30 13:53:11 2018 New Revision: 341117 URL: http://llvm.org/viewvc/llvm-project?rev=341117=rev Log: [MS ABI] Fix mangling issue with dynamic initializer stubs. There are two types of dynamic initializer stubs. There's `dynamic initializer for 'x''(void) and