Re: r344957 - Give Multiversion-inline functions linkonce linkage

2018-10-29 Thread David Blaikie via cfe-commits
ctions if the visible list of declarations is different, > but we treat that as an ODR violation.* > > > Rightio - thanks for all the context (: > > - Dave > > > > > *From:* David Blaikie [mailto:dblai...@gmail.com] > *Sent:* Monday, October 29, 2018 11:25 AM > *

RE: r344957 - Give Multiversion-inline functions linkonce linkage

2018-10-29 Thread Keane, Erich via cfe-commits
From: David Blaikie [mailto:dblai...@gmail.com] Sent: Monday, October 29, 2018 11:41 AM To: Keane, Erich Cc: Eric Christopher ; cfe-commits@lists.llvm.org Subject: Re: r344957 - Give Multiversion-inline functions linkonce linkage On Mon, Oct 29, 2018 at 11:30 AM Keane, Erich mailto:erich.ke

Re: r344957 - Give Multiversion-inline functions linkonce linkage

2018-10-29 Thread David Blaikie via cfe-commits
r < > echri...@gmail.com> > *Cc:* cfe-commits@lists.llvm.org > *Subject:* Re: r344957 - Give Multiversion-inline functions linkonce > linkage > > > > Does this match GCC's approach here? > > (I ask this sort of as throwaway/conversation starter - because the &g

RE: r344957 - Give Multiversion-inline functions linkonce linkage

2018-10-29 Thread Keane, Erich via cfe-commits
, 2018 11:25 AM To: Keane, Erich ; Eric Christopher Cc: cfe-commits@lists.llvm.org Subject: Re: r344957 - Give Multiversion-inline functions linkonce linkage Does this match GCC's approach here? (I ask this sort of as throwaway/conversation starter - because the linkage/behavior around

Re: r344957 - Give Multiversion-inline functions linkonce linkage

2018-10-29 Thread David Blaikie via cfe-commits
Does this match GCC's approach here? (I ask this sort of as throwaway/conversation starter - because the linkage/behavior around multiversion functions and their inlining is full of sharp corners/risks of code moving out of the areas appropriately restricted based on the cpu features) On Mon,

r344957 - Give Multiversion-inline functions linkonce linkage

2018-10-22 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Oct 22 14:20:45 2018 New Revision: 344957 URL: http://llvm.org/viewvc/llvm-project?rev=344957=rev Log: Give Multiversion-inline functions linkonce linkage Since multiversion variant functions can be inline, in C they become available-externally linkage. This ends up