Re: r345009 - [DebugInfo] Generate debug information for labels. (After fix PR39094)

2018-10-23 Thread Hans Wennborg via cfe-commits
I found another assert (two really) caused by this patch. Reproducer for one of them here: https://bugs.chromium.org/p/chromium/issues/detail?id=898160#c3 On Tue, Oct 23, 2018 at 6:19 AM, Hans Wennborg wrote: > This broke Chromium again. I've reverted in rr345026 > > See

Re: r345009 - [DebugInfo] Generate debug information for labels. (After fix PR39094)

2018-10-23 Thread Hans Wennborg via cfe-commits
This broke Chromium again. I've reverted in rr345026 See https://bugs.chromium.org/p/chromium/issues/detail?id=898152#c1 for the reproducer. On Tue, Oct 23, 2018 at 1:06 AM, Hsiangkai Wang via cfe-commits wrote: > Author: hsiangkai > Date: Tue Oct 23 01:06:21 2018 > New Revision: 345009 > >

r345026 - Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix PR39094)"

2018-10-23 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Oct 23 06:17:13 2018 New Revision: 345026 URL: http://llvm.org/viewvc/llvm-project?rev=345026=rev Log: Revert r345009 "[DebugInfo] Generate debug information for labels. (After fix PR39094)" This broke the Chromium build. See https://bugs.chromium.org/p/chrom

r345009 - [DebugInfo] Generate debug information for labels. (After fix PR39094)

2018-10-23 Thread Hsiangkai Wang via cfe-commits
Author: hsiangkai Date: Tue Oct 23 01:06:21 2018 New Revision: 345009 URL: http://llvm.org/viewvc/llvm-project?rev=345009=rev Log: [DebugInfo] Generate debug information for labels. (After fix PR39094) Generate DILabel metadata and call llvm.dbg.label after label statement to associate the