Re: r345330 - Add MS ABI mangling for operator<=>.

2018-10-26 Thread Hans Wennborg via cfe-commits
It seems the generated MS mangling differs between 32- and 64-bit, and the test expects the latter. Let's revert in the meantime.. r345380 On Fri, Oct 26, 2018 at 1:10 PM, Peter Smith via cfe-commits wrote: > This commit, specifically the changes made to > CodeGenCXX/cxx2a-three-way-comparison.

r345380 - Revert r345330 "Add MS ABI mangling for operator<=>."

2018-10-26 Thread Hans Wennborg via cfe-commits
Author: hans Date: Fri Oct 26 06:05:45 2018 New Revision: 345380 URL: http://llvm.org/viewvc/llvm-project?rev=345380&view=rev Log: Revert r345330 "Add MS ABI mangling for operator<=>." The generated MS manglings differ between 32- and 64-bit, and the test only expects the

Re: r345330 - Add MS ABI mangling for operator<=>.

2018-10-26 Thread Peter Smith via cfe-commits
This commit, specifically the changes made to CodeGenCXX/cxx2a-three-way-comparison.cpp, are failing on all the Arm and AArch64 builders that run check-clang and some of the other non-X86 builders as well like S390 and PPC. It seems to be the // RUN: not %clang_cc1 -std=c++2a -emit-llvm %s -o - -t

Re: r345330 - Add MS ABI mangling for operator<=>.

2018-10-25 Thread Richard Smith via cfe-commits
I've already pointed Zach at this and I think he's going to handle it. On Thu, 25 Oct 2018 at 16:00, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Could you update the demangler too? > > On Thu, Oct 25, 2018 at 6:53 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.o

Re: r345330 - Add MS ABI mangling for operator<=>.

2018-10-25 Thread Nico Weber via cfe-commits
Could you update the demangler too? On Thu, Oct 25, 2018 at 6:53 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Oct 25 15:51:16 2018 > New Revision: 345330 > > URL: http://llvm.org/viewvc/llvm-project?rev=345330&view=rev > Log: > Add MS ABI mang

r345330 - Add MS ABI mangling for operator<=>.

2018-10-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Oct 25 15:51:16 2018 New Revision: 345330 URL: http://llvm.org/viewvc/llvm-project?rev=345330&view=rev Log: Add MS ABI mangling for operator<=>. Thanks to Cameron DaCamara at Microsoft for letting us know what their chosen mangling is here! Added: cfe/trunk/test/Code