Re: r348325 - [Sema] Remove some conditions of a failing assert

2018-12-05 Thread Erik Pilkington via cfe-commits
On 12/4/18 7:07 PM, Richard Smith wrote: On Tue, 4 Dec 2018 at 16:46, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: epilk Date: Tue DecĀ  4 16:43:11 2018 New Revision: 348325 URL: http://llvm.org/viewvc/llvm-project?rev=348325=rev Log:

Re: r348325 - [Sema] Remove some conditions of a failing assert

2018-12-04 Thread Richard Smith via cfe-commits
On Tue, 4 Dec 2018 at 16:46, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: epilk > Date: Tue Dec 4 16:43:11 2018 > New Revision: 348325 > > URL: http://llvm.org/viewvc/llvm-project?rev=348325=rev > Log: > [Sema] Remove some conditions of a failing assert > > We

r348325 - [Sema] Remove some conditions of a failing assert

2018-12-04 Thread Erik Pilkington via cfe-commits
Author: epilk Date: Tue Dec 4 16:43:11 2018 New Revision: 348325 URL: http://llvm.org/viewvc/llvm-project?rev=348325=rev Log: [Sema] Remove some conditions of a failing assert We should have been checking that this state is consistent, but its possible for it to be filled later, so it isn't