Thank you for that!
From: Shoaib Meenai [mailto:smee...@fb.com]
Sent: Tuesday, January 8, 2019 4:48 PM
To: David Majnemer
Cc: Keane, Erich ; cfe-commits@lists.llvm.org; Martin
Storsjo
Subject: Re: r350643 - Limit COFF 'common' emission to <=32 alignment types.
I sent out ht
m<mailto:smee...@fb.com>]
Sent: Tuesday, January 8, 2019 12:41 PM
To: Keane, Erich mailto:erich.ke...@intel.com>>;
cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>; David Majnemer
mailto:david.majne...@gmail.com>>
Subject: Re: r350643 - Limit COFF 'common' emissio
> *Date: *Tuesday, January 8, 2019 at 1:04 PM
> *To: *Shoaib Meenai , "cfe-commits@lists.llvm.org" <
> cfe-commits@lists.llvm.org>, David Majnemer
> *Subject: *RE: r350643 - Limit COFF 'common' emission to <=32 alignment
> types.
>
>
>
> Yep, exactly. I
Majnemer ; Martin Storsjo
Subject: Re: r350643 - Limit COFF 'common' emission to <=32 alignment types.
It checks for both OS=Win32 and Environment=MSVC, so that wouldn't cover other
COFF environments. wbs (Martin Storsjo) mentioned on IRC that MinGW adds an
aligncomm directive to specify alignm
January 8, 2019 at 1:04 PM
To: Shoaib Meenai , "cfe-commits@lists.llvm.org"
, David Majnemer
Subject: RE: r350643 - Limit COFF 'common' emission to <=32 alignment types.
Yep, exactly. I looked, and isKnownWindowsMSVCEnvironment checks for OS=Win32,
which I believe would
: Re: r350643 - Limit COFF 'common' emission to <=32 alignment types.
Ah, looks like you were originally checking for COFF, and then David suggested
checking for MSVC instead? I'm curious about why, although I'm sure the
suggestion is legit :)
From: cfe-commits
mailto:cfe-commits-b
at 12:39 PM
To: Erich Keane , "cfe-commits@lists.llvm.org"
Subject: Re: r350643 - Limit COFF 'common' emission to <=32 alignment types.
Why does this check for isKnownWindowsMSVCEnvironment specifically? Wouldn't
any COFF target (windows-cygnus, windows-gnu, windows-itanium, etc.) h
Reply-To: Erich Keane
Date: Tuesday, January 8, 2019 at 10:48 AM
To: "cfe-commits@lists.llvm.org"
Subject: r350643 - Limit COFF 'common' emission to <=32 alignment types.
Author: erichkeane
Date: Tue Jan 8 10:44:22 2019
New Revision: 350643
URL:
https://urldefense.proofpoint.com/
Author: erichkeane
Date: Tue Jan 8 10:44:22 2019
New Revision: 350643
URL: http://llvm.org/viewvc/llvm-project?rev=350643=rev
Log:
Limit COFF 'common' emission to <=32 alignment types.
As reported in PR33035, LLVM crashes if given a common object with an
alignment of greater than 32 bits. This
