Re: r350917 - [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto

2019-05-29 Thread Akira Hatanaka via cfe-commits
Hi Richard, Thank you for the feedback. Please review my new patch: https://reviews.llvm.org/D62645 . > On Apr 23, 2019, at 7:21 PM, Richard Smith wrote: > > Hi Akira, > > I've reverted this in r359066. This subtly breaks the semantics of C++ > initializers by

Re: r350917 - [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto

2019-04-23 Thread Richard Smith via cfe-commits
Hi Akira, I've reverted this in r359066. This subtly breaks the semantics of C++ initializers by strripping off an outer level of parentheses / braces in some cases. Testcase: struct A { A(); A(const A&) = delete; }; auto x = [a{A()}] {}; (This should be accepted in C++17 mode onwa

r350917 - [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto

2019-01-10 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Thu Jan 10 20:57:34 2019 New Revision: 350917 URL: http://llvm.org/viewvc/llvm-project?rev=350917&view=rev Log: [Sema] If CheckPlaceholderExpr rewrites the initializer of an auto variable during auto type deduction, use the rewritten initializer when performing initializatio