>> *Sent:* Friday, January 18, 2019 9:30 AM
>> *To:* Topper, Craig
>> *Cc:* cfe-commits@lists.llvm.org
>> *Subject:* Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on
>> non-windows platforms"
>>
>>
>>
>> Hi Craig,
>
what Benjamin Kramer reported on V8?
>
>
>
> *From:* Jordan Rupprecht [mailto:ruppre...@google.com]
> *Sent:* Friday, January 18, 2019 9:30 AM
> *To:* Topper, Craig
> *Cc:* cfe-commits@lists.llvm.org
> *Subject:* Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_x
what Benjamin Kramer reported on V8?
From: Jordan Rupprecht [mailto:ruppre...@google.com]
Sent: Friday, January 18, 2019 9:30 AM
To: Topper, Craig
Cc: cfe-commits@lists.llvm.org
Subject: Re: r351391 - Recommit r351160 "[X86] Make _xgetbv/_xsetbv on
non-windows platforms"
Hi Craig,
We
URL: http://llvm.org/viewvc/llvm-project?rev=351391&view=rev
> Log:
> Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"
>
> V8 has been fixed now.
>
> Modified:
> cfe/trunk/include/clang/Basic/BuiltinsX86.def
> cfe/trunk/lib/CodeGen
Author: ctopper
Date: Wed Jan 16 14:56:25 2019
New Revision: 351391
URL: http://llvm.org/viewvc/llvm-project?rev=351391&view=rev
Log:
Recommit r351160 "[X86] Make _xgetbv/_xsetbv on non-windows platforms"
V8 has been fixed now.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX
v8 is fixed, feel free to land this after the release branch :)
On Wed, Jan 16, 2019 at 12:57 AM Craig Topper
wrote:
> This isn't blocking anything. Just doing some archaeology because I
> noticed we had an intrinsic in the backend, but it wasn't used by the
> frontend due to a previous revert a
This isn't blocking anything. Just doing some archaeology because I noticed
we had an intrinsic in the backend, but it wasn't used by the frontend due
to a previous revert a couple years ago.
~Craig
On Tue, Jan 15, 2019 at 3:47 PM Benjamin Kramer wrote:
> I think the only viable solution is to
I think the only viable solution is to make v8 not define reserved
identifiers & reland this change. That will take some time, so unless this
is blocking something important I'd prefer to reland after the release cut
so the world can catch up before the next release. I can take care of
sending v8 a
any suggestions on how to proceed here?
~Craig
On Tue, Jan 15, 2019 at 10:56 AM Benjamin Kramer
wrote:
> I think the main issue is that libstdc++ 4.9 includes x86intrin.h
> transitively from . That's probably broken with all compilers :(
>
> On Tue, Jan 15, 2019 at 7:31 PM Craig Topper
> wrot
I think the main issue is that libstdc++ 4.9 includes x86intrin.h
transitively from . That's probably broken with all compilers :(
On Tue, Jan 15, 2019 at 7:31 PM Craig Topper wrote:
> Does V8 work with gcc which also has _xgetbv? Or is it because I had to
> make _xgetbv a macro to make the patc
Does V8 work with gcc which also has _xgetbv? Or is it because I had to
make _xgetbv a macro to make the patch work?
~Craig
On Tue, Jan 15, 2019 at 9:28 AM Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I rolled it back for now in r351210, this pattern seems to be quite
I rolled it back for now in r351210, this pattern seems to be quite common
even outside of v8. Let's figure out if we can keep the code working or if
it needs to be fixed all over the place :(
On Tue, Jan 15, 2019 at 3:02 PM Benjamin Kramer wrote:
> I'm seeing breakages on v8 with this, it defin
I'm seeing breakages on v8 with this, it defines its own _xgetbv. Any ideas
what do do about this?
https://chromium.googlesource.com/v8/v8.git/+/master/src/x64/assembler-x64.cc#36
src/x64/assembler-x64.cc:35:1: error: inline variables are incompatible
with C++ standards before C++17 [-Werror,-Wc+
Author: ctopper
Date: Mon Jan 14 21:03:18 2019
New Revision: 351160
URL: http://llvm.org/viewvc/llvm-project?rev=351160&view=rev
Log:
[X86] Make _xgetbv/_xsetbv on non-windows platforms
Summary:
This patch attempts to redo what was tried in r278783, but was reverted.
These intrinsics should be a
14 matches
Mail list logo
