RE: r351495 - Make integral-o-pointer conversions in SFINAE illegal.

2019-01-18 Thread Keane, Erich via cfe-commits
Thanks for the heads up! Looking now. -Original Message- From: Peter Smith [mailto:peter.sm...@linaro.org] Sent: Friday, January 18, 2019 2:33 AM To: Keane, Erich Cc: cfe-commits cfe Subject: Re: r351495 - Make integral-o-pointer conversions in SFINAE illegal. Hello Erich, The test

Re: r351495 - Make integral-o-pointer conversions in SFINAE illegal.

2019-01-18 Thread Peter Smith via cfe-commits
Hello Erich, The test added in this commit is failing on the Arm and Hexagon builders. I think that this is because the expected type "long" in the warning text is "int" on these platforms (possibly other 32-bit host platforms). The raw output from an Arm machine is:

r351495 - Make integral-o-pointer conversions in SFINAE illegal.

2019-01-17 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu Jan 17 15:11:15 2019 New Revision: 351495 URL: http://llvm.org/viewvc/llvm-project?rev=351495=rev Log: Make integral-o-pointer conversions in SFINAE illegal. As reported in PR40362, allowing the conversion from an integral to a pointer type (despite being illegal in