Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

I see. You're right the name sounds slow indeed. Thank you for the explanation! > On Feb 19, 2019, at 6:43 AM, Nico Weber wrote: > > I didn't realize it just copied a string. I just saw a call to > "fillRealPathName" and the "RealPath" bit sounded slow. From clicking around > in http://llvm-cs

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

I didn't realize it just copied a string. I just saw a call to "fillRealPathName" and the "RealPath" bit sounded slow. From clicking around in http://llvm-cs.pcc.me.uk/tools/clang/lib/Basic/FileManager.cpp#361 it looks like it's not really computing a realpath (for symlinks). It still does quite a

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Hi Nico, I didn't think it necessary as the change doesn't introduce any interaction with filesystem - it's just copying a string. Do you mean it causes a performance regression? Thanks. Jan > On Feb 15, 2019, at 6:15 AM, Nico Weber wrote: > > Did you do any performance testing to check if

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Hi all, Sorry, my bad, I was out on Friday. Will re-land patch with fixed test shortly. Jan > On Feb 15, 2019, at 12:47 PM, Reid Kleckner wrote: > > Reverted: > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/4351 >

r354169 - Revert r354075 "[clang][FileManager] fillRealPathName even if we aren't opening the file"

Author: rnk Date: Fri Feb 15 12:48:12 2019 New Revision: 354169 URL: http://llvm.org/viewvc/llvm-project?rev=354169&view=rev Log: Revert r354075 "[clang][FileManager] fillRealPathName even if we aren't opening the file" The new test doesn't pass on Windows. Modified:

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Reverted: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/4351 On Fri, Feb 15, 2019 at 11:07 AM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Jan, > > It looks like this commit broke tests on couple of win builders: > > http://lab.llvm.org:8011/buil

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Hello Jan, It looks like this commit broke tests on couple of win builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/23655 http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win . . . Failing Tests (1): Clang-Unit :: Basic/./Ba

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Did you do any performance testing to check if this slows down clang? On Thu, Feb 14, 2019 at 6:02 PM Jan Korous via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jkorous > Date: Thu Feb 14 15:02:35 2019 > New Revision: 354075 > > URL: http://llvm.org/viewvc/llvm-project?rev=354075&v

r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Author: jkorous Date: Thu Feb 14 15:02:35 2019 New Revision: 354075 URL: http://llvm.org/viewvc/llvm-project?rev=354075&view=rev Log: [clang][FileManager] fillRealPathName even if we aren't opening the file The pathname wasn't previously filled when the getFile() method was called with openFile