Re: r361278 - [clang][Darwin] Refactor header search path logic into the driver

Hello Louis, This commit broke few tests on the next builder: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/17776 Please have a look ASAP? . . . Failing Tests (4): Clang :: Driver/darwin-header-search-libcxx.cpp Clang ::

RE: r361278 - [clang][Darwin] Refactor header search path logic into the driver

lang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\tools\clang\test\Driver/Inputs/basic_darwin_toolchain", the value of TOOLCHAIN as expected by FileCheck is "C:\\\\ps4-buildslave2llvm-clang-lld-x86_64-scei-ps4-windows10pro-fastllvm\\.srctoolsclangtestDriver/Inputs/ba

Re: r361278 - [clang][Darwin] Refactor header search path logic into the driver

Awesome! But... this resulted in two test failures for me. I've fixed them in r361301, can you check that's correct? On Tue, 21 May 2019 at 10:45, Louis Dionne via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ldionne > Date: Tue May 21 10:48:04 2019 > New Revision: 361278 > > URL:

r361278 - [clang][Darwin] Refactor header search path logic into the driver

Author: ldionne Date: Tue May 21 10:48:04 2019 New Revision: 361278 URL: http://llvm.org/viewvc/llvm-project?rev=361278=rev Log: [clang][Darwin] Refactor header search path logic into the driver Summary: This commit moves the logic for determining system, resource and C++ header search paths