RE: r362119 - Add Attribute NoThrow as an Exception Specifier Type

2019-05-31 Thread Keane, Erich via cfe-commits
[mailto:tha...@chromium.org] Sent: Friday, May 31, 2019 6:58 AM To: Keane, Erich Cc: Aaron Ballman ; cfe-commits Subject: Re: r362119 - Add Attribute NoThrow as an Exception Specifier Type I'm not sure this is the best fix. From the patch description, it sounds like this is a Microsoft-specific

RE: r362119 - Add Attribute NoThrow as an Exception Specifier Type

2019-05-31 Thread Keane, Erich via cfe-commits
To: Keane, Erich Cc: Aaron Ballman ; cfe-commits Subject: Re: r362119 - Add Attribute NoThrow as an Exception Specifier Type I'm not sure this is the best fix. From the patch description, it sounds like this is a Microsoft-specific change. So splitting this into a new diag group that then everyone

Re: r362119 - Add Attribute NoThrow as an Exception Specifier Type

2019-05-31 Thread Nico Weber via cfe-commits
> *Cc:* cfe-commits > *Subject:* Re: r362119 - Add Attribute NoThrow as an Exception Specifier > Type > > > > Hello, > > > > this causes this diagnostic when building on Windows: > > > > In file included from > ../../ui/accessibi

RE: r362119 - Add Attribute NoThrow as an Exception Specifier Type

2019-05-31 Thread Keane, Erich via cfe-commits
: Thursday, May 30, 2019 6:15 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r362119 - Add Attribute NoThrow as an Exception Specifier Type Hello, this causes this diagnostic when building on Windows: In file included from ../../ui/accessibility/platform

Re: r362119 - Add Attribute NoThrow as an Exception Specifier Type

2019-05-30 Thread Nico Weber via cfe-commits
Hello, this causes this diagnostic when building on Windows: In file included from ../../ui/accessibility/platform/ax_platform_node_textchildprovider_win.cc:10: ../..\ui/accessibility/platform/ax_platform_node_textprovider_win.h(22,3): error: 'nothrow' attribute conflicts with exception

r362119 - Add Attribute NoThrow as an Exception Specifier Type

2019-05-30 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Thu May 30 10:31:54 2019 New Revision: 362119 URL: http://llvm.org/viewvc/llvm-project?rev=362119=rev Log: Add Attribute NoThrow as an Exception Specifier Type In response to https://bugs.llvm.org/show_bug.cgi?id=33235, it became clear that the current mechanism of