Re: r362551 - Convert MemberExpr creation and serialization to work the same way as

2019-06-05 Thread Richard Smith via cfe-commits
On Wed, 5 Jun 2019, 04:44 Benjamin Kramer via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > It also crashes during clang selfhost with modules and libc++. Let me know > if you need a precise reproducer command. > Yes, please. I reverted this change and the dependent r362563 in r362597. >

Re: r362551 - Convert MemberExpr creation and serialization to work the same way as

2019-06-05 Thread Benjamin Kramer via cfe-commits
It also crashes during clang selfhost with modules and libc++. Let me know if you need a precise reproducer command. I reverted this change and the dependent r362563 in r362597. On Wed, Jun 5, 2019 at 9:37 AM Martin Storsjö via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This broke buildi

Re: r362551 - Convert MemberExpr creation and serialization to work the same way as

2019-06-05 Thread Martin Storsjö via cfe-commits
This broke building of Qt when using PCH. Selfcontained repro is a bit hard to make though... // Martin On Tue, 4 Jun 2019, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Jun 4 14:29:28 2019 New Revision: 362551 URL: http://llvm.org/viewvc/llvm-project?rev=362551&view=rev Log

r362551 - Convert MemberExpr creation and serialization to work the same way as

2019-06-04 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 4 14:29:28 2019 New Revision: 362551 URL: http://llvm.org/viewvc/llvm-project?rev=362551&view=rev Log: Convert MemberExpr creation and serialization to work the same way as most / all other Expr subclasses. Modified: cfe/trunk/include/clang/AST/Expr.h cfe/tru