Re: r369830 - NFC: Rename some sanitizer related lifetime checks

2019-08-27 Thread David Zarzycki via cfe-commits
Hi Vitaly, Thanks for fixing this! And I’m sorry about accidentally disabling the test entirely by adding “REQUIRES: assertions” instead of “REQUIRES: asserts”. Dave > On Aug 27, 2019, at 1:10 AM, Vitaly Buka wrote: > > fixed with r369992 > > On Mon, Aug 26, 2019 at 1:16 PM Vitaly Buka

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

2019-08-26 Thread Vitaly Buka via cfe-commits
fixed with r369992 On Mon, Aug 26, 2019 at 1:16 PM Vitaly Buka wrote: > Thank for the try, but it's not the fix as it just disabled the test > everywhere as no one sets "assertions". > Also I am not sure how the patch can break the test, it just renamed the > files. Which bot was that? > Is it

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

2019-08-26 Thread Vitaly Buka via cfe-commits
Thank for the try, but it's not the fix as it just disabled the test everywhere as no one sets "assertions". Also I am not sure how the patch can break the test, it just renamed the files. Which bot was that? Is it possible that your local checkout just had the test disabled? On Sat, Aug 24, 2019

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

2019-08-24 Thread David Zarzycki via cfe-commits
Fix: r369843 Please confirm. Thanks! > On Aug 24, 2019, at 8:18 AM, David Zarzycki wrote: > > This seems to have broken building on Red Hat Fedora Linux 30 (x86_64). Was > this expected? > > FAIL: Clang :: CodeGenCXX/lifetime-sanitizer.cpp (7750 of 50751) > TEST 'Clang

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

2019-08-24 Thread David Zarzycki via cfe-commits
This seems to have broken building on Red Hat Fedora Linux 30 (x86_64). Was this expected? FAIL: Clang :: CodeGenCXX/lifetime-sanitizer.cpp (7750 of 50751) TEST 'Clang :: CodeGenCXX/lifetime-sanitizer.cpp' FAILED Script: -- : 'RUN: at line 1';

r369830 - NFC: Rename some sanitizer related lifetime checks

2019-08-23 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Aug 23 18:31:38 2019 New Revision: 369830 URL: http://llvm.org/viewvc/llvm-project?rev=369830=rev Log: NFC: Rename some sanitizer related lifetime checks Added: cfe/trunk/test/CodeGen/lifetime-sanitizer.c cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp