Author: epilk Date: Wed Aug 28 15:38:36 2019 New Revision: 370270 URL: http://llvm.org/viewvc/llvm-project?rev=370270&view=rev Log: Fix a passing XFAIL test
Now that we can gracefully handle stack exhaustion, this test was passing in darwin && asan. Instead, just unsupport it when threading is unavailable. Modified: cfe/trunk/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp Modified: cfe/trunk/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp?rev=370270&r1=370269&r2=370270&view=diff ============================================================================== --- cfe/trunk/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp (original) +++ cfe/trunk/test/CodeGenCXX/castexpr-basepathsize-threshold.cpp Wed Aug 28 15:38:36 2019 @@ -3,9 +3,9 @@ // https://bugs.llvm.org/show_bug.cgi?id=38356 // We only check that we do not crash. -// ASAN increases stack usage, so we are hitting stack overflow before reaching -// recursive template instantiation limit. -// XFAIL: darwin && asan +// This test can exceed stack usage in some configurations, so unless we can +// properly handle that don't run it. +// REQUIRES: thread_support template <typename a, a b(unsigned), int c, unsigned...> struct d : d<a, b, c - 1> {}; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits