Re: r372681 - Support for DWARF-5 C++ language tags.

2019-10-02 Thread David Blaikie via cfe-commits
Yeah, something about linkage - but that's not the part that's as likely to be a problem as the other part: the other test for C++ language was what causes LLVM to compute the fully qualified name of an entity in the accelerator table ("foo::bar" instead of just "bar" (eg: the bug was things like

Re: r372681 - Support for DWARF-5 C++ language tags.

2019-10-02 Thread Adrian Prantl via cfe-commits
>> On Oct 1, 2019, at 6:40 PM, David Blaikie wrote: >> >> This broke gnu_pubnames and other forms of DWARF index of C++ code - fixed >> in r373420 (feel free to post-comimt review, etc, of course) >> > patch for reference: >case dwarf::DW_TAG_union_type: >case

Re: r372681 - Support for DWARF-5 C++ language tags.

2019-10-02 Thread David Blaikie via cfe-commits
Out of curiosity, should/would this've shown up for you Apple folks too? (as a failure in the apple/lldb accelerator tables - because the names would be similarly incorrect) had it just not got to the necessary testing yet? On Wed, Oct 2, 2019 at 8:29 AM Adrian Prantl wrote: > > > On Oct 1,

Re: r372681 - Support for DWARF-5 C++ language tags.

2019-10-02 Thread Adrian Prantl via cfe-commits
> On Oct 1, 2019, at 6:40 PM, David Blaikie wrote: > > This broke gnu_pubnames and other forms of DWARF index of C++ code - fixed in > r373420 (feel free to post-comimt review, etc, of course) > Thanks! -- adrian > On Mon, Sep 23, 2019 at 5:36 PM Adrian Prantl via cfe-commits >

Re: r372681 - Support for DWARF-5 C++ language tags.

2019-10-01 Thread David Blaikie via cfe-commits
This broke gnu_pubnames and other forms of DWARF index of C++ code - fixed in r373420 (feel free to post-comimt review, etc, of course) On Mon, Sep 23, 2019 at 5:36 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Mon Sep 23 17:38:49 2019 > New

r372681 - Support for DWARF-5 C++ language tags.

2019-09-23 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Sep 23 17:38:49 2019 New Revision: 372681 URL: http://llvm.org/viewvc/llvm-project?rev=372681=rev Log: Support for DWARF-5 C++ language tags. This patch provides support for DW_LANG_C_plus_plus_11, DW_LANG_C_plus_plus_14 tags in the Clang C++ frontend. Patch by Sourabh